datepicker: parseDate is now case insensitive #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atepicker: parseDate is case sensitive.
|
Thanks for this fix. Please file a bug for this at http://dev.jqueryui.com/newticket (requires registration) and update your commit message based on http://wiki.jqueryui.com/Commit-Message-Style-Guide. |
|
I thought the commit message was in the correct format. What have I missed? |
|
Sorry, I didn't see the whole commit message because of the view I was in. You've done everything right. Landed in 590e03c. Thanks. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parseDate function was case sensitive.
When opening based on a textbox of '01 Mar 2010' it correctly showed that date.
When opening based on a textbox of '01 mar 2010' it did not recognise the date and showed today's date instead.
I've changed this behaviour so that when comparing against the array of names it now converts both sides of the comparison to lower case.